Re: [PATCH v1 1/1] iio: adc: ad7191: Don't check for specific errors when parsing properties

[Andy Shevchenko]

On Fri, Feb 20, 2026 at 12:04 PM Nuno Sá <noname.nuno@xxxxxxxxx> wrote:
> On Thu, 2026-02-19 at 15:39 +0100, Andy Shevchenko wrote:
> > Instead of checking for the specific error codes (that can be considered
> > a layering violation to some extent) check for the property existence first
> > and then either parse it, or apply a default value.
>
> Not really sure how I feel about this one. Checking for specific errors is a very common
> pattern and this change just makes it we check for the property presence twice. That said,
> this makes it more "future proof" (though I find it very unlikely for ret value o change).

I already have an answer to this:
https://lore.kernel.org/r/aZcenabXYsOdBu84@xxxxxxxxxxxxxxxxxx

> Anyways, even if we choose to go down this route, I don't see much benefit in starting
> converting the drivers with the pattern below (which should be a considerable number).

There is not a big number of them, so I prefer to have common patterns
without exact error code checks.

-- 
With Best Regards,
Andy Shevchenko