Re: [PATCH v1 1/1] iio: adc: ad7192: Revert "properly check spi_get_device_match_data()"

[Jonathan Cameron]

On Wed, 18 Feb 2026 09:58:20 +0000
Jonathan Cameron <jonathan.cameron@xxxxxxxxxx> wrote:

> On Wed, 18 Feb 2026 11:40:11 +0200
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> 
> > On Wed, Feb 18, 2026 at 09:12:03AM +0000, Nuno Sá wrote:  
> > > On Tue, 2026-02-17 at 17:06 +0200, Andy Shevchenko wrote:    
> > > > On Tue, Feb 17, 2026 at 01:47:59PM +0000, Nuno Sá wrote:    
> > > > > On Tue, 2026-02-17 at 09:05 +0100, Andy Shevchenko wrote:    
> > 
> > ...
> >   
> > > > > I'm ok with this but as long as we get some consistency agreed on. So far,
> > > > > IIRC, the policy was to check for the NULL case even for the cases where that
> > > > > was not possible to happen.    
> > > > 
> > > > Is it kernel-wide policy?    
> > > 
> > > Nope... Just IIO IIRC. Actually, I'm pretty sure we had patches in the past
> > > just adding the check.    
> > 
> > Like you said we need clearer policy.
> >   
> > > But again, I'm fine with the above as long as we are consistent from now on.    
> > 
> > Exactly!
> > Jonathan, David, others?  
> 
> As long as no compilers or static analyzers trip up on it and start spouting false warnings,
> I'm fine with not checking these. I'm not sure I'm bothered about going through the tree
> removing the checks though.   This one is so small I don't mind if it gets copied
> into new drivers. If this is all that needs tidying up I'll tweak it whilst applying.
> 
Applied.  I also added a link tag to this thread, to say we had
agreed to make it policy in IIO to not have these checks.

Thanks,

Jonathan

> Jonathan
> 
> 
> >   
>