Re: [PATCH v1 1/1] iio: core: Simplify IIO core managed APIs
From: Andy Shevchenko
Date: Fri Feb 20 2026 - 08:30:34 EST
On Fri, Feb 20, 2026 at 12:14:50PM +0000, Jonathan Cameron wrote:
> On Fri, 20 Feb 2026 12:27:40 +0200
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Feb 20, 2026 at 12:18 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> > > On Mon, 16 Feb 2026 09:14:12 +0100
> > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
...
> > > This had me briefly confused as I failed to notice it was static
> > > (no idea why I gave such a simple internal function kernel-doc!)
> > >
> > > However that brings the obvious follow up question. Given your
> > > simplification does having a helper make sense given only a single caller?
> > >
> > > Let's just squash it and have the two calls inline + some resulting docs
> > > updates to get rid of the references to this function.
> >
> > Do you want to have this change inside the proposed patch? Or in a
> > separate (pre/post) one?
> Same patch would be fine I think. It's small and coupled to the code
> getting simpler because of the main change here. Seems like a pointless
> dance to refactor same code twice.
v2 has just been sent.
--
With Best Regards,
Andy Shevchenko