Re: [PATCH] usb: ehci-orion: remove optional PHY handling code remnants
From: Miquel Raynal
Date: Fri Feb 20 2026 - 08:48:14 EST
Hi Gabor,
On 20/02/2026 at 14:27:02 +01, Gabor Juhos <j4g8y7@xxxxxxxxx> wrote:
> Since the USB core code handles the generic USB PHYs automatically, the
> optional PHY handling code has been removed from the 'ehci-orion' driver
> entirely by commit e04585184dcf ("usb: ehci-orion: avoid double PHY
> initialization"). However, the devm_phy_optional_get() call has been kept
> so the driver still gets the PHY even though it is not used for anything
> in the driver.
>
> Drop the remaining code, and also remove the 'phy' member of the
> 'orion_ehci_hcd' structure to simplify the code.
>
> Fixes: e04585184dcf ("usb: ehci-orion: avoid double PHY initialization")
The fixes tag makes no sense here, this is pure cleanup. I do not
remember if this was needed or not, it is probably safe to drop today.
Cheers,
Miquèl