Re: [PATCH 2/6] nvme: update nvme_id_ns OPTPERF constants
From: Christoph Hellwig
Date: Fri Feb 20 2026 - 11:07:58 EST
On Thu, Feb 19, 2026 at 08:28:05PM -0700, Caleb Sander Mateos wrote:
> Since NVM Command Spec 1.1, OPTPERF comprises both bits 4 and 5 of
> NSFEAT in the Identify Namespace structure. Replace NVME_NS_FEAT_IO_OPT,
> which represented only bit 4, with NVME_NS_FEAT_OPTPERF_SHIFT and
> NVME_NS_FEAT_OPTPERF_MASK.
As you're deeper in this than me: do the older specs require the
other bit to be cleared to zero and this is all compatible? Or do
we need to guard it somehow?
Otherwise looks good.