Re: [PATCH 6/6] nvmet: report NPDGL and NPDAL
From: Christoph Hellwig
Date: Fri Feb 20 2026 - 11:15:48 EST
On Thu, Feb 19, 2026 at 08:28:09PM -0700, Caleb Sander Mateos wrote:
> A block device with a very large discard_granularity queue limit may not
> be able to report it in the 16-bit NPDG and NPDA fields in the Identify
> Namespace data structure. For this reason, version 2.1 of the NVMe specs
> added 32-bit fields NPDGL and NPDAL to the NVM Command Set Specific
> Identify Namespace structure. So report the discard_granularity there
> too and set OPTPERF to 11b to indicate those fields are supported.
>From a pure mechanics point of view this looks fine. I'll not that
actually aligning the discard to these granularities probably won't
really work for most file systems, though.