Re: [PATCH v3] hrtimer: add usage examples to documentation
From: Miguel Ojeda
Date: Fri Feb 20 2026 - 13:19:11 EST
On Fri, Feb 20, 2026 at 9:12 AM Andreas Hindborg <a.hindborg@xxxxxxxxxx> wrote:
>
> +//! prelude::*,
The prelude should already be there in examples.
> +//! sync::{
> +//! atomic::{ordering, Atomic},
> +//! completion::Completion,
> +//! Arc,
> +//! },
> +//! time::{
> +//! hrtimer::{
> +//! RelativeMode, HrTimer, HrTimerCallback, HrTimerPointer,
> +//! HrTimerRestart, HrTimerCallbackContext
> +//! },
> +//! Delta, Monotonic,
> +//! },
> +//! };
This uses a mixture of the vertical style and the horizontal one -- I
guess you did it to save on lines, but it looks strange now that we
have a style for imports.
I guess you thought about it, but I wonder if the examples could be
merged to some degree to make them more readable...
Cheers,
Miguel