Re: [PATCH 3/5] ARM: dts: bcm4709-asus-rt-ac87u: specify switch

[Rafał Miłecki]

pt., 20 lut 2026 o 22:18 Rosen Penev <rosenp@xxxxxxxxx> napisał(a):
> On Fri, Feb 20, 2026 at 3:18 AM Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
> > pt., 20 lut 2026 o 03:14 Rosen Penev <rosenp@xxxxxxxxx> napisał(a):
> > > bcm-ns.dtsi specifies a default layout that is not correct for the
> > > RT-AC87U. Also allows setting the WAN MAC address properly.
> >
> > How the basic ports info from bcm-ns.dtsi is not correct for RT-AC87U?
> > I don't see you doing any overwriting or /delete-node/. It seems like
> > a standard NS device with BCM53011 and 8 ports (0, 1, 2, 3, 4, 5, 7,
> > 8), three of them connected to no-SoC Ethernet interfaces.
> This comes from a local OpenWrt patch. I just added the nvmem
> definition for WAN.
>
> There's also the addition of labels.

Then I guess someone else didn't try hard enough for proper
description. It happens with downstream code. Sometimes it suffers
from lower quality & hacks.

When submitting for upstream you can improve it though :-) You can
(and rather should) reword commit description so it's accurate.

-- 
Rafał