Re: [PATCH] wifi: rt2x00: use non of nvmem_cell_get

[Rosen Penev]

On Fri, Feb 20, 2026 at 2:37 AM Stanislaw Gruszka <stf_xl@xxxxx> wrote:
>
> On Thu, Feb 19, 2026 at 06:09:08PM -0800, Rosen Penev wrote:
> > The library doesn't necessarily depend on OF. This codepath is used by
> > both soc (OF only) and pci (no such requirement). After this, the only
> > of specific function is of_get_mac_address, which is needed for nvmem.
> >
> > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> Acked-by: Stanislaw Gruszka <stf_xl@xxxxx>
>
> > ---
> >  drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > index 65d0f805459c..93e4ce604171 100644
> > --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > @@ -10965,13 +10965,13 @@ EXPORT_SYMBOL_GPL(rt2800_read_eeprom_efuse);
> >
> >  int rt2800_read_eeprom_nvmem(struct rt2x00_dev *rt2x00dev)
> >  {
> > -     struct device_node *np = rt2x00dev->dev->of_node;
> > +     struct device *dev = rt2x00dev->dev;
> >       unsigned int len = rt2x00dev->ops->eeprom_size;
> >       struct nvmem_cell *cell;
> >       const void *data;
> >       size_t retlen;
> >
> > -     cell = of_nvmem_cell_get(np, "eeprom");
> > +     cell = nvmem_cell_get(dev, "eeprom");
most usages of nvmem_cell_get in wireless use devm instead. Seems
pointless to extend the lifetime of cell until removal but what do I
know...
> >       if (IS_ERR(cell))
> >               return PTR_ERR(cell);
> >
> > --
> > 2.53.0
> >