Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code
From: Conor Dooley
Date: Fri Feb 20 2026 - 17:39:15 EST
On Fri, Feb 20, 2026 at 11:38:03PM +0800, Jisheng Zhang wrote:
> On Sat, Feb 14, 2026 at 10:38:02AM +0800, Kunwu Chan wrote:
> > Fix a few minor issues found in riscv XIP-related code:
>
> 'RESEND' isn't expected to be used as you did in this series.
> You sent the v1 series on Feb 14, only 4 days ago, the series doesn't
> miss any dev window.
> https://lore.kernel.org/linux-riscv/8ee1b065-b021-411b-b5ee-22c4a108cbce@xxxxxxxxx/T/#t
v1 wasn't threaded correctly, so I think a resend is fine as the content
didn't change.
> > - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab
> > - head.S: spelling typo and wrong #endif comment
>
> I'm sorry, but how important is fixing comment/spelling typo or #endif
> comment among maintainship?
It's not, but I think we've made this point already!
> The riscv XIP code doesn't stand on itself,
> but heavily affects and is affected by other riscv arch common code.
Attachment:
signature.asc
Description: PGP signature