Re: [PATCH 1/6] nvme: add preferred I/O size fields to struct nvme_id_ns_nvm

[Caleb Sander Mateos]

On Fri, Feb 20, 2026 at 8:06 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Thu, Feb 19, 2026 at 08:28:04PM -0700, Caleb Sander Mateos wrote:
> > A subsequent change will use the NPDGL and NPDAL fields of the NVM
> > Command Set Specific Identify Namespace structure, so add them (and the
> > handful of intervening fields) to struct nvme_id_ns_nvm.
>
> Looks good.  Btw, as the kernel now has a the global scope static_assert,
> can you add that too any on the wire format struct you touch to ensure
> our modifications aren't changing the sizses?

Looks like static_assert() was added 3 years before struct nvme_id_ns_nvm :)
Definitely agree it's good to assert on these struct sizes.

>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Assuming you meant "Reviewed-by". Let me know if you meant something else.

Thanks,
Caleb