Re: [PATCH net v1] net: defer __dev_set_promiscuity() to avoid sleeping in atomic context
From: Stanislav Fomichev
Date: Sat Feb 21 2026 - 01:23:49 EST
On 02/21, I Viswanath wrote:
> On Sat, 21 Feb 2026 at 06:45, Stanislav Fomichev <stfomichev@xxxxxxxxx> wrote:
> > > Do you mean rtnl_lock when you say instance lock?
> >
> > Search for the instance locks in Documentation/networking/netdevices.rst. We
> > essentially need to add netdev_ops_assert_locked to __dev_set_rx_mode
> > and make it work.
>
> So, the handler should look something like this?
>
> static void netif_write_rx_mode(struct work_struct *param) {
> rtnl_lock()
> netdev_lock()
> /* Processing */
> netdev_unlock();
> rtnl_unlock();
> }
>
> v9 should be out by next week and fixes all the issues I could think
> of so please wait for that
Let's handle instance locking separately, I don't think it's as simple
as adding netdev_ops_lock/unlock.