Re: [PATCH] HID: quirks: really enable the intended work around for appledisplay

[Jiri Kosina]

On Thu, 5 Feb 2026, René Rebe wrote:

> > From: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxxx>
> > 
> > Commit c7fabe4ad921 ("HID: quirks: work around VID/PID conflict for
> > appledisplay") intends to add a quirk for kernels built with Apple Cinema
> > Display support, but it refers to the non-existing config option
> > CONFIG_APPLEDISPLAY, whereas the config option for Apple Cinema Display
> > support is named CONFIG_USB_APPLEDISPLAY.
> > 
> > Refer to the intended config option CONFIG_USB_APPLEDISPLAY in the ifdef
> > directive.
> > 
> > Fixes: c7fabe4ad921 ("HID: quirks: work around VID/PID conflict for appledisplay")
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxxx>
> > ---
> > 
> > Note this fix suggests that the patch of commit c7fabe4ad921 in this form
> > was never effectively tested, checking the effect that the commit message
> > claims it would have.
> 
> Thanks for spotting this. It was tested when I did this years ago. Though, maybe I
> tested before adding the #if IS_ENABLED, anciently hit some key in Vim, o
> something was renamed since then.
> 
> Either way, I’ll get the display out of the basement and re-test it the coming days.

Is there any results of this testing, please?

Thanks,

-- 
Jiri Kosina
SUSE Labs