Re: [PATCH 1/3] dt-bindings: regulator: Document Unisoc SC2730 PMIC bindings

[Krzysztof Kozlowski]

On Fri, Feb 20, 2026 at 06:01:49PM +0100, Otto Pflüger wrote:
> Add bindings for the regulators found in the Spreadtrum/Unisoc SC2730
> PMIC, used e.g. with the UMS512 and UMS9230 SoCs.
> 
> Signed-off-by: Otto Pflüger <otto.pflueger@xxxxxxxxx>
> ---
>  .../bindings/regulator/sprd,sc2730-regulator.yaml  | 51 ++++++++++++++++++++++
>  1 file changed, 51 insertions(+)

So your second patch depends on it, but nothing in cover letter or this
patch changelog explain that making it extra difficult for maintainers.
You want them to guess the dependencies?

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

It is just "ADD"

> 
> diff --git a/Documentation/devicetree/bindings/regulator/sprd,sc2730-regulator.yaml b/Documentation/devicetree/bindings/regulator/sprd,sc2730-regulator.yaml
> new file mode 100644
> index 000000000000..36f5f4d338bb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/sprd,sc2730-regulator.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/sprd,sc2730-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc SC2730 Power Management IC regulators
> +
> +maintainers:
> +  - Otto Pflüger <otto.pflueger@xxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    const: sprd,sc2730-regulator

Let's drop the compatible (which changes my comment on other patch as
you can put only $ref in oneOf).

> +
> +patternProperties:
> +  "^DCDC_(CORE|CPU|GEN[0-1]|GPU|MEM|MEMQ|MODEM|SRAM)$":

All names are lowercase without underscores. See DTS coding style.

Best regards,
Krzysztof