Re: [PATCH 1/3] dt-bindings: regulator: Document Unisoc SC2730 PMIC bindings

[Krzysztof Kozlowski]

On 21/02/2026 14:02, Otto Pflüger wrote:
> On Sat, Feb 21, 2026 at 11:52:55AM +0100, Krzysztof Kozlowski wrote:
>> [...]
>>> +properties:
>>> +  compatible:
>>> +    const: sprd,sc2730-regulator
>>
>> Let's drop the compatible (which changes my comment on other patch as
>> you can put only $ref in oneOf).
> 
> Sorry, I don't quite understand this part. It seems that you are
> suggesting to change the top-level MFD bindings in the other patch to
> look like this:
> 
>   regulators:
>     type: object
>     oneOf:
>       - $ref: /schemas/regulator/sprd,sc2730-regulator.yaml#
>       - $ref: /schemas/regulator/sprd,sc2731-regulator.yaml#

Yes

> 
> If that's the case, how should the regulator bindings for SC2730 be
> distinguished from SC2731 without the compatible? Would it be fine to

They don't have to be distinguished. The parent (so main node)
compatible defines everything.

> keep the compatible here if I drop the additional if/then constraints in
> the other patch?

But I also said that you can have if:then: defining the $ref... and then
you would notice that you actually need to split the binding.


Best regards,
Krzysztof