Re: [PATCH v10 1/2] dt-bindings: hwmon: add support for MCP998X

[Krzysztof Kozlowski]

On 20/02/2026 15:58, Victor.Duicu@xxxxxxxxxxxxx wrote:
> Hi Krzysztof,
> 
>>
>>
>> ...
>>
>>
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - microchip,mcp9933
>>> +      - microchip,mcp9933d
>>> +      - microchip,mcp9982
>>> +      - microchip,mcp9982d
>>> +      - microchip,mcp9983
>>> +      - microchip,mcp9983d
>>> +      - microchip,mcp9984
>>> +      - microchip,mcp9984d
>>> +      - microchip,mcp9985
>>> +      - microchip,mcp9985d
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>
>> Your interrupt-names say 1 item is correct, so these are de-synced.
>> They
>> should be always constrained the same way.
>>
> 
> We want to allow the user to use none, one or both interrupts.

Who is the "user" here? IOW, can the *hardware* work correctly without
the interrupt line connected anywhere?

> It was my mistake to set maxItems instead of minItems to interrupts.
> Do you find the following approach agreeable?
> 
>   interrupts:
>     minItems: 1

missing maxItems

> 
>   interrupt-names:
>     minItems: 1
>     items:
>       - enum: [alert-therm, therm-addr, sys-shtdwn]
>       - enum: [therm-addr, sys-shtdwn]

If any combination is allowed, then it is correct code.

> 
> ...
> 
> Thank you for your reply,
> Victor


Best regards,
Krzysztof