Re: [PATCH] soc: rockchip: grf: fix device node refcount leak in error path
From: Heiko Stübner
Date: Sat Feb 21 2026 - 09:52:23 EST
Hi,
Am Samstag, 21. Februar 2026, 01:40:27 Mitteleuropäische Normalzeit schrieb xiaopeitux@xxxxxxxxxxx:
> From: Pei Xiao <xiaopei01@xxxxxxxxxx>
>
> The for_each_matching_node_and_match() macro automatically manages device
> node reference counts during normal iteration. However, when breaking out
> of the loop early with return, the current iteration's node is not
> automatically released, leading to a reference count leak.
>
> Fix this by adding of_node_put() before returning from the loop
> when fails.
>
> Fixes: 75fb63ae0312 ("soc: rockchip: grf: Support multiple grf to be handled")
> Signed-off-by: Pei Xiao <xiaopei01@xxxxxxxxxx>
Felix Gu was slightly faster [0], so I'll apply their patch once the merge-
window is closed.
Thanks
Heiko
[0] http://lore.kernel.org/r/20260217-grf-v1-1-2088c966875d@xxxxxxxxx