Re: [PATCH v2] media: vidtv: fix pass-by-value structs causing MSAN warnings

[Daniel Almeida]

Hi there, thanks for your contribution.

> On 21 Feb 2026, at 09:56, Abd-Alrhman Masalkhi <abd.masalkhi@xxxxxxxxx> wrote:
> 
> vidtv_ts_null_write_into() and vidtv_ts_pcr_write_into() take their
> argument structs by value, causing MSAN to report uninit-value warnings.
> While only vidtv_ts_null_write_into() has triggered a report so far,
> both functions share the same issue.
> 
> Fix by passing both structs by const pointer instead, avoiding the
> stack copy of the struct along with its MSAN shadow and origin metadata.
> The functions do not modify the structs, which is enforced by the const
> qualifier.
> 
> Fixes: f90cf6079bf67 ("media: vidtv: add a bridge driver")
> Reported-by: syzbot+96f901260a0b2d29cd1a@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=96f901260a0b2d29cd1a
> Tested-by: syzbot+96f901260a0b2d29cd1a@xxxxxxxxxxxxxxxxxxxxxxxxx
> Suggested-by: Yihan Ding <dingyihan@xxxxxxxxxxxxx>
> Signed-off-by: Abd-Alrhman Masalkhi <abd.masalkhi@xxxxxxxxx>
> —

I will eventually get to this patch.

— Daniel