Re: [PATCH 4/7] Input: cros_ec_keyb - use BIT() macro instead of open-coding shifts

From: Tzung-Bi Shih

Date: Sun Feb 22 2026 - 05:47:39 EST


On Sat, Feb 21, 2026 at 04:37:12PM -0800, Dmitry Torokhov wrote:
> Using the macro clarifies the code.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>

> @@ -780,8 +780,7 @@ static int cros_ec_keyb_register_matrix(struct cros_ec_keyb *ckdev)
> idev->dev.parent = dev;
> idev->setkeycode = cros_ec_keyb_setkeycode;
>
> - ckdev->ghost_filter = device_property_read_bool(dev,
> - "google,needs-ghost-filter");
> + ckdev->ghost_filter = device_property_read_bool(dev, "google,needs-ghost-filter");

This change seems unrelated to the patch, but it's fine as-is. I don't think
it requires a separate commit.