Re: [PATCH v4 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance

[Jonathan Cameron]

On Sat, 21 Feb 2026 17:21:23 +0000
Taha Ed-Dafili <0rayn.dev@xxxxxxxxx> wrote:

> I did go over the datasheet and found the hardware uses a single
> register for both tap thresholds, so I assume the VALUE was intentionally
> omitted from DOUBLETAP to avoid duplicate sysfs attributes.
> 
> I mechanically added the scale attribute without realizing this. I will
> drop BIT(IIO_EV_INFO_SCALE) for double tap and update the docs in v5.

If the underlying register applies to two different events and it's not
possible to combine them using shared_by_ (which I don't think it is here)
then we should have attributes for both of them.

The IIO ABI always allows any write to any channel property including event
thresholds to change the value of a different one, so there is never a problem
with duplication like this

thanks,

Jonathan

> 
> I'll wait a couple of days for any other feedback before sending the
> next version.