Re: [PATCH v2 2/3] irqchip/irq-pruss-intc: Fix listed IRQ type in /proc/interrupts

[Thomas Gleixner]

On Wed, Feb 18 2026 at 15:07, Meghana Malladi wrote:
> From: Grygorii Strashko <grygorii.strashko@xxxxxx>
>
> The PRUSS INTC driver doesn't have .irq_set_type() callback implemented and
> supports only IRQ_TYPE_LEVEL_HIGH. This resulted in the IRQ properties not
> being updated properly and the PRUSS INTC IRQs were listed incorrectly in
> /proc/interrupts as Edge.

That's again incomprehensible word salad. If the driver only supports
edge then obviously all interrupts belonging to this chip are marked
edge. How should they be listed?

> Example:
>   218:          0  4b220000.interrupt-controller  26 Edge      pru10

That's really useful information because nobody knows how
/proc/interrupt output looks like.

> Fix this by adding a simple .irq_set_type() implementation which checks the
> requested IRQ triggering type.

And how does that list the the PRUSS interrupts magically with some
other type than edge?

> Fixes: 04e2d1e06978 ("irqchip/irq-pruss-intc: Add a PRUSS irqchip driver for PRUSS interrupts")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> Signed-off-by: Suman Anna <s-anna@xxxxxx>
> Link: https://lore.kernel.org/all/20230919061900.369300-3-danishanwar@xxxxxx/
> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx>
> Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx>
> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> Signed-off-by: Meghana Malladi <m-malladi@xxxxxx>

Amazing how many people it takes to get such a trivial fix to LKML and
that none of them noticed that the change log does not make any sense at all.
  
Thanks,

        tglx