Re: [PATCH v10 6/8] rust: gpu: Add GPU buddy allocator bindings

[Joel Fernandes]

On 2/20/2026 6:43 PM, Danilo Krummrich wrote:
> On Fri Feb 20, 2026 at 10:20 PM CET, Joel Fernandes wrote:
>>
>>
>> On 2/20/2026 10:53 AM, Danilo Krummrich wrote:
>>> On Fri Feb 20, 2026 at 3:54 PM CET, Joel Fernandes wrote:
>>>>
>>>>
>>>> On 2/20/2026 3:22 AM, Eliot Courtney wrote:
>>>>> On Thu Feb 19, 2026 at 5:55 AM JST, Joel Fernandes wrote:
>>>>>> +__rust_helper u64 rust_helper_gpu_buddy_block_size(struct gpu_buddy *mm,
>>>>>> +						   struct gpu_buddy_block *block)
>>>>>> +{
>>>>>> +	return gpu_buddy_block_size(mm, block);
>>>>>> +}
>>>>>> +
>>>>>
>>>>> Will `rust_helper_gpu_buddy_block_size` be used in the future? It
>>>>> doesn't appear to be used in buddy.rs.
>>>>
>>>> I think it is worth keeping because it is a pretty basic API the underlying
>>>> infrastructure. Finding the size of a block can be important in the future
>>>> IMO. It is only few lines, no?
>>>
>>> The helper should be added with the code using it.
>>
>> I will add this as a test case to exercise it and include it in that patch.
> 
> A test case for a helper? Or do you mean you will add the actual abstraction?

Actual abstraction.

thanks,

--
Joel Fernandes