[PATCH 7/9] mfd: ezx-pcap: Return directly instead of empty gotos

From: Krzysztof Kozlowski

Date: Mon Feb 23 2026 - 02:29:06 EST


Code is easier to read if empty error paths simply return, instead of
jumping to empty label doing only "return ret".

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
---
drivers/mfd/ezx-pcap.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
index 13cb185638a9..b929559d84ae 100644
--- a/drivers/mfd/ezx-pcap.c
+++ b/drivers/mfd/ezx-pcap.c
@@ -384,17 +384,15 @@ static int ezx_pcap_probe(struct spi_device *spi)
struct pcap_platform_data *pdata = dev_get_platdata(&spi->dev);
struct pcap_chip *pcap;
int i, adc_irq;
- int ret = -ENODEV;
+ int ret;

/* platform data is required */
if (!pdata)
- goto ret;
+ return -ENODEV;

pcap = devm_kzalloc(&spi->dev, sizeof(*pcap), GFP_KERNEL);
- if (!pcap) {
- ret = -ENOMEM;
- goto ret;
- }
+ if (!pcap)
+ return -ENOMEM;

spin_lock_init(&pcap->io_lock);
spin_lock_init(&pcap->adc_lock);
@@ -407,17 +405,15 @@ static int ezx_pcap_probe(struct spi_device *spi)
spi->mode = SPI_MODE_0 | (pdata->config & PCAP_CS_AH ? SPI_CS_HIGH : 0);
ret = spi_setup(spi);
if (ret)
- goto ret;
+ return ret;

pcap->spi = spi;

/* setup irq */
pcap->irq_base = pdata->irq_base;
pcap->workqueue = create_singlethread_workqueue("pcapd");
- if (!pcap->workqueue) {
- ret = -ENOMEM;
- goto ret;
- }
+ if (!pcap->workqueue)
+ return -ENOMEM;

/* redirect interrupts to AP, except adcdone2 */
if (!(pdata->config & PCAP_SECOND_PORT))

--
2.51.0