Re: [PATCH v2 11/11] staging: rtl8723bs: rtw_ieee80211: Reduce global symbols

[Dan Carpenter]

On Sat, Feb 21, 2026 at 09:01:41PM +0200, Priit Laes wrote:
> Mark internally used symbols/functions as static and drop some unused
> ones.
> WPA_CIPHER_SUITE_WRAP/RSN_CIPHER_SUITE_WRAP are left as commented, as
> these might be actually useful for understanding the code.
> 
> Changes since v1:
> * Comment out unused variables WPA_CIPHER_SUITE_WRAP/RSN_CIPHER_SUITE_WRAP

Put this under the --- cut off line

> 
> Signed-off-by: Priit Laes <plaes@xxxxxxxxx>
> ---
  ^^^
Here.

But really we're not going to allow commented out code.  Just delete
it.  There are reasons why people would merge dead code, such as for
example, in some cases code needs legal approval and it's easier to get
everything approved at once even when it's not needed immediately.  But
here we're not going to allow it.

This would be easier to review as separate patches:
[patch 1] Delete dead code.
[patch 2] make functions static
[patch 3] move the arrays and make them static const

regards,
dan carpenter