Re: [PATCH V5 1/2] soundwire: amd: add clock init control function

[Mukunda,Vijendar]

On 2/23/26 12:51, Vinod Koul wrote:
> On 05-02-26, 22:14, Vijendar Mukunda wrote:
> > Add generic SoundWire clock initialization sequence to support
> > different SoundWire bus clock frequencies for ACP6.3/7.0/7.1/7.2
> > platforms and remove hard coding initializations for 12Mhz bus
> > clock frequency.
> >
> > Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx>
> > ---
> >   drivers/soundwire/amd_manager.c | 52 ++++++++++++++++++++++++++++-----
> >   drivers/soundwire/amd_manager.h |  4 ---
> >   2 files changed, 45 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
> > index 5fd311ee4107..b53f781e4e74 100644
> > --- a/drivers/soundwire/amd_manager.c
> > +++ b/drivers/soundwire/amd_manager.c
> > @@ -27,6 +27,45 @@
> >   
> >   #define to_amd_sdw(b)	container_of(b, struct amd_sdw_manager, bus)
> >   
> > +static int amd_sdw_clk_init_ctrl(struct amd_sdw_manager *amd_manager)
> > +{
> > +	struct sdw_bus *bus = &amd_manager->bus;
> > +	struct sdw_master_prop *prop = &bus->prop;
> > +	u32 val;
> > +	int divider;
> In which case can divider be negative?
divider won't be negative. will change it to unsigned variable.
> > +
> > +	dev_dbg(amd_manager->dev, "mclk %d max %d row %d col %d frame_rate:%d\n",
> > +		prop->mclk_freq, prop->max_clk_freq, prop->default_row,
> > +		prop->default_col, prop->default_frame_rate);
> Okay dumping properties
Will keep only this debug statement and will drop rest of the debug
statements.
> > +
> > +	if (!prop->default_frame_rate || !prop->default_row) {
> > +		dev_err(amd_manager->dev, "Default frame_rate %d or row %d is invalid\n",
> > +			prop->default_frame_rate, prop->default_row);
> > +		return -EINVAL;
> > +	}
> > +
> > +	/* Set clock divider */
> > +	dev_dbg(amd_manager->dev, "bus params curr_dr_freq: %d\n",
> > +		bus->params.curr_dr_freq);
> Now freq
Will drop the debug statement.
> > +	divider = (prop->mclk_freq / bus->params.curr_dr_freq);
> > +
> > +	writel(divider, amd_manager->mmio + ACP_SW_CLK_FREQUENCY_CTRL);
> > +	val = readl(amd_manager->mmio + ACP_SW_CLK_FREQUENCY_CTRL);
> > +	dev_dbg(amd_manager->dev, "ACP_SW_CLK_FREQUENCY_CTRL:0x%x\n", val);
> register
Will drop the debug statement.
> > +
> > +	/* Set frame shape base on the actual bus frequency. */
> > +	prop->default_col = bus->params.curr_dr_freq /
> > +			    prop->default_frame_rate / prop->default_row;
> > +
> > +	dev_dbg(amd_manager->dev, "default_frame_rate:%d default_row: %d default_col: %d\n",
> > +		prop->default_frame_rate, prop->default_row, prop->default_col);
> again properties
>
> I think that is bit too much debug spew. Good for bringup but a lot of
> noise during production. Properties can be looked from debugfs. I would
> retain the one with clock rates applied and get rid of rest...
Will drop the debug statement and re-spin the patch set.
> > +	amd_manager->cols_index = sdw_find_col_index(prop->default_col);
> > +	amd_manager->rows_index = sdw_find_row_index(prop->default_row);
> > +	bus->params.col = prop->default_col;
> > +	bus->params.row = prop->default_row;
> > +	return 0;
> > +}
> > +
> >   static int amd_init_sdw_manager(struct amd_sdw_manager *amd_manager)
> >   {
> >   	u32 val;
> > @@ -961,6 +1000,9 @@ int amd_sdw_manager_start(struct amd_sdw_manager *amd_manager)
> >   
> >   	prop = &amd_manager->bus.prop;
> >   	if (!prop->hw_disabled) {
> > +		ret = amd_sdw_clk_init_ctrl(amd_manager);
> > +		if (ret)
> > +			return ret;
> >   		ret = amd_init_sdw_manager(amd_manager);
> >   		if (ret)
> >   			return ret;
> > @@ -985,7 +1027,6 @@ static int amd_sdw_manager_probe(struct platform_device *pdev)
> >   	struct resource *res;
> >   	struct device *dev = &pdev->dev;
> >   	struct sdw_master_prop *prop;
> > -	struct sdw_bus_params *params;
> >   	struct amd_sdw_manager *amd_manager;
> >   	int ret;
> >   
> > @@ -1049,14 +1090,8 @@ static int amd_sdw_manager_probe(struct platform_device *pdev)
> >   		return -EINVAL;
> >   	}
> >   
> > -	params = &amd_manager->bus.params;
> > -
> > -	params->col = AMD_SDW_DEFAULT_COLUMNS;
> > -	params->row = AMD_SDW_DEFAULT_ROWS;
> >   	prop = &amd_manager->bus.prop;
> > -	prop->clk_freq = &amd_sdw_freq_tbl[0];
> >   	prop->mclk_freq = AMD_SDW_BUS_BASE_FREQ;
> > -	prop->max_clk_freq = AMD_SDW_DEFAULT_CLK_FREQ;
> >   
> >   	ret = sdw_bus_master_add(&amd_manager->bus, dev, dev->fwnode);
> >   	if (ret) {
> > @@ -1348,6 +1383,9 @@ static int __maybe_unused amd_resume_runtime(struct device *dev)
> >   			}
> >   		}
> >   		sdw_clear_slave_status(bus, SDW_UNATTACH_REQUEST_MASTER_RESET);
> > +		ret = amd_sdw_clk_init_ctrl(amd_manager);
> > +		if (ret)
> > +			return ret;
> >   		amd_init_sdw_manager(amd_manager);
> >   		amd_enable_sdw_interrupts(amd_manager);
> >   		ret = amd_enable_sdw_manager(amd_manager);
> > diff --git a/drivers/soundwire/amd_manager.h b/drivers/soundwire/amd_manager.h
> > index 6cc916b0c820..88cf8a426a0c 100644
> > --- a/drivers/soundwire/amd_manager.h
> > +++ b/drivers/soundwire/amd_manager.h
> > @@ -203,10 +203,6 @@
> >   #define AMD_SDW_DEVICE_STATE_D3				3
> >   #define ACP_PME_EN					0x0001400
> >   
> > -static u32 amd_sdw_freq_tbl[AMD_SDW_MAX_FREQ_NUM] = {
> > -	AMD_SDW_DEFAULT_CLK_FREQ,
> > -};
> > -
> >   struct sdw_manager_dp_reg {
> >   	u32 frame_fmt_reg;
> >   	u32 sample_int_reg;
> > --
> > 2.45.2