Re: [PATCH v2 4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree

From: Frieder Schrempf

Date: Mon Feb 23 2026 - 03:35:07 EST


On 20.02.26 13:27, Daniel Baluta wrote:
> On 2/20/26 13:57, Fabio Estevam wrote:
>> On Fri, Feb 20, 2026 at 8:20 AM Daniel Baluta <daniel.baluta@xxxxxxxxxxx> wrote:
>>> On 2/20/26 12:36, Frieder Schrempf wrote:
>>>> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>>>>
>>>> To make the code more readable, use the macros for the GPIO and IRQ
>>>> settings.
>>>>
>>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>>>> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
>>>
>>> Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags
>>>
>>> in the commit message above.
>> Is this suggestion valid?
>>
>> Shouldn't the tags appear in chronological order?
>
> Tools like b4 indeed are taking the tags in chronological order.
> But I always considered that when sending next version you pick all the tags
>
> and then add your Signed-off-by last.
>
> E.g https://www.spinics.net/lists/kernel/msg5995225.html

I've always been adding the collected tags below my S-o-b tag. And I've
never heard any complaints from the i.MX subsystem maintainers, so I
assume it is ok like that and there is no need to change anything.

As far as I know most other subsystems also don't have strict rules for
the tag order.