Re: [PATCH v2] usb: ehci-orion: remove optional PHY handling code remnants

From: Miquel Raynal

Date: Mon Feb 23 2026 - 03:46:10 EST


On 21/02/2026 at 10:02:37 +01, Gabor Juhos <j4g8y7@xxxxxxxxx> wrote:

> Since the USB core code handles the generic USB PHYs automatically, the
> optional PHY handling code has been removed from the 'ehci-orion' driver
> entirely by commit e04585184dcf ("usb: ehci-orion: avoid double PHY
> initialization"). However, the devm_phy_optional_get() call has been kept
> so the driver still gets the PHY even though it is not used for anything
> in the driver.
>
> Drop the remaining code, and also remove the 'phy' member of the
> 'orion_ehci_hcd' structure to simplify the code.
>
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Gabor Juhos <j4g8y7@xxxxxxxxx>

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Thanks!
Miquèl