Re: [PATCH] iio: adc: ad7173: move opening brace to a separate line

From: Andy Shevchenko

Date: Mon Feb 23 2026 - 03:52:13 EST


On Mon, Feb 23, 2026 at 12:40:10PM +0400, Giorgi Tchankvetadze wrote:
> On Mon, Feb 23, 2026 at 12:32 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> >
> > On Mon, Feb 23, 2026 at 12:24:00PM +0400, Giorgi Tchankvetadze wrote:
> > > Place the opening brace of ad7173_calc_openwire_thrsh_raw() on its own
> > > line to comply with the kernel coding style for function definitions.
> > > Issue found by checkpatch.
> >
> > Is it the only problem like this in the entire driver?
> > If so, feel free to add
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>
> Thanks for the review, Andy. Yes, it is the only instance of this
> issue in the driver. I verified with checkpatch and a manual grep for
> function definitions with opening braces on the same line.

Thanks for confirming, no need to resend with my tag, the tooling
Jonathan uses picks this up.

--
With Best Regards,
Andy Shevchenko