Re: [PATCH] EDAC/versalnet: Fix resource leaks and NULL derefs in init_versalnet()
From: Eric_Terminal
Date: Mon Feb 23 2026 - 05:14:52 EST
On Mon, Feb 23, 2026 at 4:54 PM Borislav Petkov <bp@xxxxxxxxx> wrote:
> In my not-so-short experience no new submitter just reads all of the submitting-patches document without complaining at least a little and
> replies with a new version of the patch - all that in three hours, and all that in way too polished English.
To explain the "way too polished English": English is not my native
language. Because I want to show proper respect to the kernel
community, I relied on translation and grammar tools to make sure my
replies were polite and appropriate. That is why the text might look
artificially perfect.
As for not complaining: I don't know how other submitters do it, but
as a newcomer, I honestly didn't dare to complain on the mailing list.
I simply assumed that complaining would leave a bad impression and
might get my patch rejected. So I just tried my best to read the
documentation and follow the rules as quickly as possible.
Regarding the speed of sending a "new version" in three hours: it
wasn't a rewrite of the patch. I merely updated the Signed-off-by tag
to my real name, re-signed it with patatt, and sent it out. The code
itself didn't change at all, which is why it was fast.
> If I look at the actual diff, am I going to find a bunch of nonsensical AI slop and am I going to waste my time talking to an AI bot as a result?
If I were a fully automated AI bot, I probably wouldn't have made the
very human mistakes of top-posting and forgetting to "Reply-to-all" in
my email before the last one. :)
I completely understand your concern about AI-generated spam.
However, the NULL pointer dereferences and memory leaks in
init_versalnet() are genuine logical flaws. I hope you can take a
brief moment to review the actual v2 diff. If there is any technical
issue with my code, I am more than happy to learn and correct it.
Best regards,
Yufan Chen (Eric Terminal)