Re: [PATCH v10 1/2] dt-bindings: hwmon: add support for MCP998X

[Krzysztof Kozlowski]

On 23/02/2026 12:09, Victor.Duicu@xxxxxxxxxxxxx wrote:
> 
>>>
> ...
> 
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    enum:
>>>>> +      - microchip,mcp9933
>>>>> +      - microchip,mcp9933d
>>>>> +      - microchip,mcp9982
>>>>> +      - microchip,mcp9982d
>>>>> +      - microchip,mcp9983
>>>>> +      - microchip,mcp9983d
>>>>> +      - microchip,mcp9984
>>>>> +      - microchip,mcp9984d
>>>>> +      - microchip,mcp9985
>>>>> +      - microchip,mcp9985d
>>>>> +
>>>>> +  reg:
>>>>> +    maxItems: 1
>>>>> +
>>>>> +  interrupts:
>>>>
>>>> Your interrupt-names say 1 item is correct, so these are de-
>>>> synced.
>>>> They
>>>> should be always constrained the same way.
>>>>
>>>
>>> We want to allow the user to use none, one or both interrupts.
>>
>> Who is the "user" here? IOW, can the *hardware* work correctly
>> without
>> the interrupt line connected anywhere?
>>
> 
> Yes, the hardware can work while the interrupt lines are not connected.

Almost there...

> At the moment the driver does not support interrupts.


...and ruined it. This does not matter and using it as argument means I
do not believe you actually checked if hardware can work without
interrupt lines connected. You only checked the driver. Please read your
datasheet carefully.

Best regards,
Krzysztof