Re: [PATCH bpf-next 3/3] selftests/bpf: factor out get_func_* tests for fsession

[Ilya Leoshkevich]

On 2/23/26 09:40, Menglong Dong wrote:
> The fsession is already supported by x86_64, arm64, riscv and s390, so we
> don't need to disable it in the compile time according to the
> architecture. Factor out the testings for it. Therefore, the testing can
> be disabled for the architecture that doesn't support it manually.
>
> Signed-off-by: Menglong Dong <dongml2@xxxxxxxxxxxxxxx>
> ---
>   .../bpf/prog_tests/get_func_args_test.c       | 25 +++++++++++-
>   .../bpf/prog_tests/get_func_ip_test.c         | 28 +++++++++++++-
>   .../bpf/progs/get_func_args_fsession_test.c   | 37 ++++++++++++++++++
>   .../selftests/bpf/progs/get_func_args_test.c  | 38 -------------------
>   .../bpf/progs/get_func_ip_fsession_test.c     | 21 ++++++++++
>   .../selftests/bpf/progs/get_func_ip_test.c    | 23 -----------
>   6 files changed, 108 insertions(+), 64 deletions(-)
>   create mode 100644 tools/testing/selftests/bpf/progs/get_func_args_fsession_test.c
>   create mode 100644 tools/testing/selftests/bpf/progs/get_func_ip_fsession_test.c


I personally like the "let the test fail on unsupported architectures" 
philosophy, since it lets architecture maintainers notice missing 
features more easily and take action (even if it's just adding the 
respective test to DENYLIST), so:


Acked-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx>