Re: [PATCH v5 05/13] soc: qcom: geni-se: Add resources activation/deactivation helpers

[Praveen Talari]

Hi Konrad,

On 2/17/2026 5:32 PM, Konrad Dybcio wrote:
> On 2/6/26 6:41 PM, Praveen Talari wrote:
> > The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource
> > activation/deactivation sequences independently, leading to code
> > duplication.
> >
> > Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to
> > power on/off resources.The activate function enables ICC, clocks, and TLMM
> > whereas the deactivate function disables resources in reverse order
> > including OPP rate reset, clocks, ICC and TLMM.
> >
> > Signed-off-by: Praveen Talari <praveen.talari@xxxxxxxxxxxxxxxx>
> > ---
> > v4 -> v5
> > Konrad
> > - updated return value as 0 for geni_se_resources_activate().
>
> I would really like you to include that kerneldoc bit I mentioned it
>
> https://lore.kernel.org/linux-arm-msm/ff9a2aa3-1b2b-4001-82ce-198c61a4b637@xxxxxxxxxxxxxxxx/

I hope the below works for you.

+/**
+ * geni_se_resources_activate() - Activate GENI SE device resources
+ * @se: Pointer to the geni_se structure
+ *
+ * Activates device resources for operation: enables interconnect, 
prepares clocks,
+ * and sets pin control to default state. Includes error cleanup. Skips 
ACPI devices.
+ *
+ * Return: 0 on success, negative error code on failure
+ */
+int geni_se_resources_activate(struct geni_se *se)
+{
+       int ret;
+
+       if (has_acpi_companion(se->dev))
+               return 0;
+
+       ret = geni_icc_enable(se);
+       if (ret)
+               return ret;
+
+       ret = geni_se_clks_on(se);
+       if (ret)
+               goto out_icc_disable;
+
+       ret = pinctrl_pm_select_default_state(se->dev);
+       if (ret) {
+               geni_se_clks_off(se);
+               goto out_icc_disable;
+       }
+
+       if (se->has_opp && se->cur_rate)
+               ret = dev_pm_opp_set_rate(se->dev, se->cur_rate);
+
+       return ret;
+
+out_icc_disable:
+       geni_icc_disable(se);
+       return ret;
+}
+EXPORT_SYMBOL_GPL(geni_se_resources_activate);
+
 /**
  * geni_se_resources_init() - Initialize resources for a GENI SE device.
  * @se: Pointer to the geni_se structure representing the GENI SE device.
diff --git a/include/linux/soc/qcom/geni-se.h 
b/include/linux/soc/qcom/geni-se.h
index c182dd0f0bde..2f7aba4f89b3 100644
--- a/include/linux/soc/qcom/geni-se.h
+++ b/include/linux/soc/qcom/geni-se.h
@@ -65,6 +65,7 @@ struct geni_icc_path {
  * @clk_perf_tbl:      Table of clock frequency input to serial engine 
clock
  * @icc_paths:         Array of ICC paths for SE
  * @has_opp:           Indicates if OPP is supported
+ * @cur_rate:          Current clock rate of the serial engine
  */
 struct geni_se {
        void __iomem *base;
@@ -76,6 +77,7 @@ struct geni_se {
        unsigned long *clk_perf_tbl;
        struct geni_icc_path icc_paths[3];
        bool has_opp;
+       unsigned long cur_rate;
 };

Thanks,
Praveen Talari

> Konrad