Re: [PATCH v3 2/4] staging: greybus: fixed styling issue in fw-management.c
From: Greg Kroah-Hartman
Date: Mon Feb 23 2026 - 08:58:17 EST
On Mon, Feb 16, 2026 at 10:33:59AM +0530, Rachit Dhar wrote:
> On Sat, Feb 7, 2026 at 7:08 PM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > What specific style issue was fixed? Please be specific.
> >
> > Also, your patches were not correctly linked together. Please use
> > something like 'git send-email' to send them all at once. Otherwise
> > they get lost and out-of-order as you can see in the email archives on
> > lore.kernel.org.
>
> The style issue fixed was for the following checkpatch check:
>
> CHECK: Alignment should match open parenthesis
> #437: FILE: drivers/staging/greybus/fw-management.c:437:
> + ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
> + intf_load.load_method, intf_load.firmware_tag);
>
> Thanks for pointing out the issue of out-of-order patches.
> I did use git send-email, but did so for each patch separately,
> which might have led to this. If I should send another patch series
> to correct this, please let me know.
I can't take these as-is, so yes, please rebase and resend the remaining
ones.
thanks,
greg k-h