Re: [PATCH v2 03/12] iio: frequency: admv1014: introduce struct device variable

[Andy Shevchenko]

On Mon, Feb 23, 2026 at 03:13:54PM +0200, Antoniu Miclaus wrote:
> Add struct device *dev local variable to simplify repeated &spi->dev
> dereferences. Where spi is no longer needed beyond &spi->dev, replace
> struct spi_device *spi with struct device *dev = &st->spi->dev.
> 
> No functional change.

...

>  static int admv1014_init(struct admv1014_state *st)
>  {
>  	unsigned int chip_id, enable_reg, enable_reg_msk;
> -	struct spi_device *spi = st->spi;
> +	struct device *dev = &st->spi->dev;
>  	int ret;
>  
>  	ret = regulator_bulk_enable(ADMV1014_NUM_REGULATORS, st->regulators);
>  	if (ret) {
> -		dev_err(&spi->dev, "Failed to enable regulators");
> +		dev_err(dev, "Failed to enable regulators");
>  		return ret;

This should be translated to dev_err_probe(). Since devm_*() is used in this
function it's assumed it's only run from ->probe() stage, and hence error
messages may be converted to use dev_err_probe().

>  	}

...

>  	if (ret) {
> -		dev_err(&spi->dev, "ADMV1014 SPI software reset failed.\n");
> +		dev_err(dev, "ADMV1014 SPI software reset failed.\n");
>  		return ret;
>  	}

Ditto.

...

>  	if (ret) {
> -		dev_err(&spi->dev, "ADMV1014 SPI software reset disable failed.\n");
> +		dev_err(dev, "ADMV1014 SPI software reset disable failed.\n");
>  		return ret;
>  	}

>  	ret = __admv1014_spi_write(st, ADMV1014_REG_VVA_TEMP_COMP, 0x727C);
>  	if (ret) {
> -		dev_err(&spi->dev, "Writing default Temperature Compensation value failed.\n");
> +		dev_err(dev, "Writing default Temperature Compensation value failed.\n");
>  		return ret;
>  	}

Ditto.

...


>  	chip_id = FIELD_GET(ADMV1014_CHIP_ID_MSK, chip_id);
>  	if (chip_id != ADMV1014_CHIP_ID) {
> -		dev_err(&spi->dev, "Invalid Chip ID.\n");
> +		dev_err(dev, "Invalid Chip ID.\n");
>  		return -EINVAL;
>  	}

Ditto.

...

>  	if (ret) {
> -		dev_err(&spi->dev, "Writing Quad SE Mode failed.\n");
> +		dev_err(dev, "Writing Quad SE Mode failed.\n");
>  		return ret;
>  	}
>  
>  	ret = admv1014_update_quad_filters(st);
>  	if (ret) {
> -		dev_err(&spi->dev, "Update Quad Filters failed.\n");
> +		dev_err(dev, "Update Quad Filters failed.\n");
>  		return ret;
>  	}
>  
>  	ret = admv1014_update_vcm_settings(st);
>  	if (ret) {
> -		dev_err(&spi->dev, "Update VCM Settings failed.\n");
> +		dev_err(dev, "Update VCM Settings failed.\n");
>  		return ret;
>  	}

Ditto.

...

> static int admv1014_properties_parse(struct admv1014_state *st)

> -	ret = devm_regulator_bulk_get(&st->spi->dev, ADMV1014_NUM_REGULATORS,
> +	ret = devm_regulator_bulk_get(dev, ADMV1014_NUM_REGULATORS,
>  				      st->regulators);
>  	if (ret) {
> -		dev_err(&spi->dev, "Failed to request regulators");
> +		dev_err(dev, "Failed to request regulators");
>  		return ret;
>  	}

Same here.

-- 
With Best Regards,
Andy Shevchenko