Re: [PATCH v4 2/2] staging: sm750fb: remove Hungarian notation prefixes

[Greg KH]

On Sun, Feb 08, 2026 at 10:43:44AM -0800, Shreyas Ravi wrote:
> Remove Hungarian notation prefixes from variable names to comply
> with kernel coding style.
> 
> No functional changes.
> 
> Signed-off-by: Shreyas Ravi <shreyasravi320@xxxxxxxxx>
> ---
> Changes in v4:
> - Fix merge conflicts (forgot to do in v3)
> 
> Changes in v3:
> - Added changelog (was missing in v2)
> 
> Changes in v2:
> - Split original patch into two patches per Greg's feedback
> - This patch addresses Hungarian prefix removal
> ---
>  drivers/staging/sm750fb/sm750.c       | 22 ++++++------
>  drivers/staging/sm750fb/sm750.h       |  6 ++--
>  drivers/staging/sm750fb/sm750_accel.c | 48 +++++++++++++--------------
>  drivers/staging/sm750fb/sm750_accel.h |  2 +-
>  drivers/staging/sm750fb/sm750_hw.c    | 20 +++++------
>  5 files changed, 49 insertions(+), 49 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 1ed7ff57c142..afcfc9e6c207 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -624,27 +624,27 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
>  		output->paths = sm750_pnc;
>  		crtc->channel = sm750_primary;
>  		crtc->o_screen = 0;
> -		crtc->v_screen = sm750_dev->p_v_mem;
> +		crtc->v_screen = sm750_dev->v_mem;

You are fixing up your patch 1 of this series, why not just do it
properly the first time?

thanks,

greg k-h