Re: [PATCH] dpll: zl3073x: Remove redundant cleanup in devm_dpll_init()

[Ivan Vecera]

On 2/23/26 2:20 PM, Felix Gu wrote:
> The devm_add_action_or_reset() function already executes the cleanup
> action on failure before returning an error, so the explicit goto error
> and subsequent zl3073x_dev_dpll_fini() call causes double cleanup.
>
> Fixes: ebb1031c5137 ("dpll: zl3073x: Refactor DPLL initialization")
> Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
> ---
>   drivers/dpll/zl3073x/core.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dpll/zl3073x/core.c b/drivers/dpll/zl3073x/core.c
> index 63bd97181b9e..4ad21caec0e8 100644
> --- a/drivers/dpll/zl3073x/core.c
> +++ b/drivers/dpll/zl3073x/core.c
> @@ -982,10 +982,8 @@ zl3073x_devm_dpll_init(struct zl3073x_dev *zldev, u8 num_dplls)
>   
>   	/* Add devres action to release DPLL related resources */
>   	rc = devm_add_action_or_reset(zldev->dev, zl3073x_dev_dpll_fini, zldev);
> -	if (rc)
> -		goto error;
>   
> -	return 0;
> +	return rc;

Please use:

return devm_add_action_or_reset(...);

Otherwise, LGTM. With this change:

Reviewed-by: Ivan Vecera <ivecera@xxxxxxxxxx>