Re: [PATCH] dt-bindings: mtd: st,spear600-smi: convert to DT schema

[Rob Herring]

On Tue, Feb 10, 2026 at 7:47 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, Jan 22, 2026 at 10:23 AM Akhila YS <akhilayalmati@xxxxxxxxx> wrote:
> >
> > Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI)
> > Controller binding to YAML format.
> >
> > Signed-off-by: Akhila YS <akhilayalmati@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/mtd/spear_smi.txt          | 29 ---------
> >  .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 72 ++++++++++++++++++++++
> >  2 files changed, 72 insertions(+), 29 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/spear_smi.txt b/Documentation/devicetree/bindings/mtd/spear_smi.txt
> > deleted file mode 100644
> > index c41873e92d26..000000000000
> > --- a/Documentation/devicetree/bindings/mtd/spear_smi.txt
> > +++ /dev/null
> > @@ -1,29 +0,0 @@
> > -* SPEAr SMI
> > -
> > -Required properties:
> > -- compatible : "st,spear600-smi"
> > -- reg : Address range of the mtd chip
> > -- #address-cells, #size-cells : Must be present if the device has sub-nodes
> > -  representing partitions.
> > -- interrupts: Should contain the STMMAC interrupts
> > -- clock-rate : Functional clock rate of SMI in Hz
> > -
> > -Optional properties:
> > -- st,smi-fast-mode : Flash supports read in fast mode
> > -
> > -Example:
> > -
> > -       smi: flash@fc000000 {
> > -               compatible = "st,spear600-smi";
> > -               #address-cells = <1>;
> > -               #size-cells = <1>;
> > -               reg = <0xfc000000 0x1000>;
> > -               interrupt-parent = <&vic1>;
> > -               interrupts = <12>;
> > -               clock-rate = <50000000>;        /* 50MHz */
> > -
> > -               flash@f8000000 {
> > -                       st,smi-fast-mode;
> > -                       ...
> > -               };
> > -       };
> > diff --git a/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
> > new file mode 100644
> > index 000000000000..8fe27aae7527
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
> > @@ -0,0 +1,72 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller
> > +
> > +maintainers:
> > +  - Richard Weinberger <richard@xxxxxx>
> > +
> > +description:
> > +  The SPEAr600 Serial Memory Interface (SMI) is a dedicated serial flash
> > +  controller supporting up to four chip selects for serial NOR flashes
> > +  connected in parallel. The controller is memory-mapped and the attached
> > +  flash devices appear in the CPU address space.The driver
> > +  (drivers/mtd/devices/spear_smi.c) probes the attached flashes
> > +  dynamically by sending commands (e.g., RDID) to each bank.
> > +  Flash sub nodes describe the memory range and optional per-flash
> > +  properties.
> > +
> > +allOf:
> > +  - $ref: mtd.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: st,spear600-smi
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 1
> > +
> > +  clock-rate:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: Functional clock rate of the SMI controller in Hz.
> > +
> > +  st,smi-fast-mode:
> > +    type: boolean
> > +    description: Indicates that the attached flash supports fast read mode.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clock-rate
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    flash@fc000000 {
> > +        compatible = "st,spear600-smi";
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> > +        reg = <0xfc000000 0x1000>;
> > +        interrupt-parent = <&vic1>;
> > +        interrupts = <12>;
> > +        clock-rate = <50000000>;  /* 50 MHz */
> > +
> > +        flash@f8000000 {
>
> This is now a warning in linux-next:

Now this is a warning in v7.0-rc1. Miquel, please revert this as there
has been no response.

>
> Documentation/devicetree/bindings/mtd/st,spear600-smi.example.dtb:
> flash@fc000000 (st,spear600-smi): Unevaluated properties are not
> allowed ('flash@f8000000' was unexpected)
>         from schema $id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml
>
> Please send a fix (and test your schemas before sending).
>
> Rob