Re: [PATCH v3 11/15] soc: qcom: aoss: Use mbox_ring_doorbell() instead of NULL message

[Bjorn Andersson]

On Mon, Feb 16, 2026 at 10:09:48AM -0800, Douglas Anderson wrote:
> As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce
> mbox_ring_doorbell()"), we want to switch all users of NULL mailbox
> messages to use mbox_ring_doorbell().
> 
> This client only ever sent NULL messages, so the transition is
> straightforward. We can remove the call to mbox_client_txdone(). The
> call didn't do anything for NULL messages and it's now officially
> documented not to be called for doorbells.
> 

Acked-by: Bjorn Andersson <andersson@xxxxxxxxxx>

Regards,
Bjorn

> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
> This driver is used on my sc7180-trogdor Chromebook. While I haven't
> stress tested with it, I can confirm that the system boots normally to
> UI and can suspend/resume with this patch in place.
> 
> (no changes since v1)
> 
>  drivers/soc/qcom/qcom_aoss.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
> index a543ab9bee6c..2ecab93239d2 100644
> --- a/drivers/soc/qcom/qcom_aoss.c
> +++ b/drivers/soc/qcom/qcom_aoss.c
> @@ -97,8 +97,7 @@ struct qmp {
>  
>  static void qmp_kick(struct qmp *qmp)
>  {
> -	mbox_send_message(qmp->mbox_chan, NULL);
> -	mbox_client_txdone(qmp->mbox_chan, 0);
> +	mbox_ring_doorbell(qmp->mbox_chan);
>  }
>  
>  static bool qmp_magic_valid(struct qmp *qmp)
> -- 
> 2.53.0.273.g2a3d683680-goog
>