Re: [PATCH net-next 3/7] bng_en: add ethtool link settings, get_link, and nway_reset

[Andrew Lunn]

> +	if (link_info->auto_pause_setting & BNGE_LINK_PAUSE_RX)
> +		linkmode_set_bit(ETHTOOL_LINK_MODE_Pause_BIT,
> +				 lk_ksettings->link_modes.advertising);
> +	if (hweight8(link_info->auto_pause_setting & BNGE_LINK_PAUSE_BOTH) == 1)
> +		linkmode_set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
> +				 lk_ksettings->link_modes.advertising);

It is not clear to me how you are configuring pause, and in particular
if pause it being autoneg or forced.

Ethtool has:

       ethtool -A|--pause devname [autoneg on|off] [rx on|off] [tx on|off]

The autoneg here is separate to global autoneg. You can have global
autoneg on, but pause autoneg off, meaning the pause configuration is
forced.

The PHY should only be advertising pause if pause autoneg is on.

    Andrew