Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Cristian Ciocaltea]

On 2/23/26 8:29 PM, Cristian Ciocaltea wrote:
> Hi Sebastian,
> 
> On 2/23/26 8:21 PM, Sebastian Reichel wrote:
>> Hi,
>>
>> On Mon, Feb 23, 2026 at 07:07:42PM +0200, Cristian Ciocaltea wrote:
>>> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>>> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>>> @@ -34,10 +34,12 @@ properties:
>>>        - description: The cache configuration registers base
>>>
>>>    reg-names:
>>> -    items:
>>> +    oneOf:
>>>        - const: function
>>> -      - const: link
>>> -      - const: cache
>>> +      - items:
>>> +          - const: link
>>> +          - const: function
>>> +          - const: cache
>>>
>>>    interrupts:
>>>      maxItems: 1
>>>
>>
>> With that change the descriptions in the reg section are wrong.
> 
> Yeah, I assumed it'd be acceptable for the description to document just once all
> possible items, to avoid repeating this for all possible combinations.
> 
> E.g. this is from Documentation/devicetree/bindings/net/snps,dwmac.yaml:
> 
>   resets:
>     minItems: 1
>     items:
>       - description: GMAC stmmaceth reset
>       - description: AHB reset
> 
>   reset-names:
>     oneOf:
>       - items:
>           - enum: [stmmaceth, ahb]
>       - items:
>           - const: stmmaceth
>           - const: ahb

I dropped the descriptions in v2, as we discussed they don't provide much value
anyway:

https://lore.kernel.org/all/20260223-vdec-reg-order-rk3576-v2-0-daf4942dfc02@xxxxxxxxxxxxx/