Re: [PATCH 2/4] arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls

[Judith Mendez]

Hello Moteen,

On 2/20/26 2:57 AM, Moteen Shah wrote:
> Hey Judith,
>
> On 13/02/26 00:12, Judith Mendez wrote:
> > AM62L EVM has external pullups on MMC0 CMD and D0 pins [0]. Remove
> > internal pullups considering:
> > - having both internal and external pullups reduces the total pull-up
> >    resistance < 47K resulting in a value below the spec recommended 
> > 50K ohms
> > - having both pullups results in unnecessary power consumption
> >
> > Fixes: 00fb4c73b67d ("arm64: dts: ti: k3-am62l: add initial reference 
> > board file")
> > [0] https://www.ti.com/lit/zip/SPRCAL6
> > Signed-off-by: Judith Mendez <jm@xxxxxx>
> > ---
> >   arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts b/arch/arm64/ 
> > boot/dts/ti/k3-am62l3-evm.dts
> > index cae04cce33736..5085cd255fcd5 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> > @@ -253,9 +253,9 @@ AM62LX_IOPAD(0x01e0, PIN_INPUT_PULLUP, 0) /* (D8) 
> > I2C2_SDA */
> >       mmc0_pins_default: mmc0-default-pins {
> >           pinctrl-single,pins = <
> > -            AM62LX_IOPAD(0x0214, PIN_INPUT_PULLUP, 0) /* (D2) 
> > MMC0_CMD */
> > +            AM62LX_IOPAD(0x0214, PIN_INPUT, 0) /* (D2) MMC0_CMD */
> >               AM62LX_IOPAD(0x020c, PIN_OUTPUT, 0) /* (B2) MMC0_CLK */
> > -            AM62LX_IOPAD(0x0208, PIN_INPUT_PULLUP, 0) /* (D3) 
> > MMC0_DAT0 */
> > +            AM62LX_IOPAD(0x0208, PIN_INPUT, 0) /* (D3) MMC0_DAT0 */
> >               AM62LX_IOPAD(0x0204, PIN_INPUT_PULLUP, 0) /* (D4) 
> > MMC0_DAT1 */
> >               AM62LX_IOPAD(0x0200, PIN_INPUT_PULLUP, 0) /* (C1) 
> > MMC0_DAT2 */
> >               AM62LX_IOPAD(0x01fc, PIN_INPUT_PULLUP, 0) /* (C2) 
> > MMC0_DAT3 */
>
>
> Wont the change result in mismatched pullup resistance and will the 
> mismatch between D0 and D1-D3 won't cause potential timing issues for 
> modes with tighter timing requirements?

If you leave the internal pullup on MMC0_DAT0, then you will have a
greater mismatch actually. But I noticed a wrong detail on the commit
description after reviewing the patches again. So will respin the
series, thanks for reviewing Moteen.
~ Judith