Re: [PATCH ath-next] wifi: ath10k: use non devm for nvmem_cell_get

[Loic Poulain]

On Mon, Feb 23, 2026 at 3:49 AM Rosen Penev <rosenp@xxxxxxxxx> wrote:
>
> There's absolutely no need to extend the lifetime of cell to post
> removal of the driver. It's only used in this function.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>

> ---
>  drivers/net/wireless/ath/ath10k/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 5c5bd5ef7175..38c5f5f95433 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -1981,13 +1981,14 @@ static int ath10k_download_cal_nvmem(struct ath10k *ar, const char *cell_name)
>         size_t len;
>         int ret;
>
> -       cell = devm_nvmem_cell_get(ar->dev, cell_name);
> +       cell = nvmem_cell_get(ar->dev, cell_name);
>         if (IS_ERR(cell)) {
>                 ret = PTR_ERR(cell);
>                 return ret;
>         }
>
>         buf = nvmem_cell_read(cell, &len);
> +       nvmem_cell_put(cell);
>         if (IS_ERR(buf))
>                 return PTR_ERR(buf);
>
> --
> 2.53.0
>
>