[PATCH v2 2/3] staging: most: dim2: use dev_err_probe and proper error codes for clock
From: Artem Lytkin
Date: Mon Feb 23 2026 - 16:09:59 EST
Replace hardcoded -EFAULT returns with dev_err_probe() and PTR_ERR()
when devm_clk_get() fails in fsl_mx6_enable(). This ensures the
correct error code is propagated (e.g. -EPROBE_DEFER for deferred
probing) and avoids log noise during probe deferral.
Signed-off-by: Artem Lytkin <iprintercanon@xxxxxxxxx>
---
drivers/staging/most/dim2/dim2.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index cea1ba99caf7..e4c8b4995c61 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -921,10 +921,9 @@ static int fsl_mx6_enable(struct platform_device *pdev)
int ret;
dev->clk = devm_clk_get(&pdev->dev, "mlb");
- if (IS_ERR(dev->clk)) {
- dev_err(&pdev->dev, "unable to get mlb clock\n");
- return -EFAULT;
- }
+ if (IS_ERR(dev->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk),
+ "unable to get mlb clock\n");
ret = clk_prepare_enable(dev->clk);
if (ret) {
@@ -936,9 +935,9 @@ static int fsl_mx6_enable(struct platform_device *pdev)
/* enable pll */
dev->clk_pll = devm_clk_get(&pdev->dev, "pll8_mlb");
if (IS_ERR(dev->clk_pll)) {
- dev_err(&pdev->dev, "unable to get mlb pll clock\n");
clk_disable_unprepare(dev->clk);
- return -EFAULT;
+ return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk_pll),
+ "unable to get mlb pll clock\n");
}
writel(0x888, dev->io_base + 0x38);
--
2.43.0