Re: [PATCH bpf v4 03/20] selftests/bpf: Replace strncpy() with strscpy()

[Ihor Solodrai]

On 2/23/26 2:28 PM, Eduard Zingerman wrote:
> On Mon, 2026-02-23 at 11:07 -0800, Ihor Solodrai wrote:
> 
> [...]
> 
>> diff --git a/tools/testing/selftests/bpf/prog_tests/align.c b/tools/testing/selftests/bpf/prog_tests/align.c
>> index 24c509ce4e5b..841a166b8081 100644
>> --- a/tools/testing/selftests/bpf/prog_tests/align.c
>> +++ b/tools/testing/selftests/bpf/prog_tests/align.c
>> @@ -633,7 +633,7 @@ static int do_test_single(struct bpf_align_test *test)
>>  	} else {
>>  		ret = 0;
>>  		/* We make a local copy so that we can strtok() it */
>> -		strncpy(bpf_vlog_copy, bpf_vlog, sizeof(bpf_vlog_copy));
>> +		strscpy(bpf_vlog_copy, bpf_vlog);
>>  		start = strstr(bpf_vlog_copy, main_pass_start);
>>  		if (!start) {
>>  			ret = 1;
> 
> This hunk no longer applies.


Hmm... Applies for me. What revision did you try?

$ git log -1 --oneline 
6de23f81a5e0 (HEAD, tag: v7.0-rc1, origin/bpf) Linux 7.0-rc1

$ b4 shazam 20260223190736.649171-1-ihor.solodrai@xxxxxxxxx
Grabbing thread from lore.kernel.org/all/20260223190736.649171-1-ihor.solodrai@xxxxxxxxx/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 22 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 103 code-review messages
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v4 1/20] selftests/bpf: Add simple strscpy() implementation
  ✓ [PATCH v4 2/20] selftests/bpf: Replace strcpy() calls with strscpy()
  ✓ [PATCH v4 3/20] selftests/bpf: Replace strncpy() with strscpy()
  ✓ [PATCH v4 4/20] selftests/bpf: Use strscpy in bpftool_helpers.c
  ✓ [PATCH v4 5/20] selftests/bpf: Use memcpy() for bounded non-NULL-terminated copies
  ✓ [PATCH v4 6/20] selftests/bpf: Pass through build flags to bpftool and resolve_btfids
  ✓ [PATCH v4 7/20] resolve_btfids: Fix memory leaks reported by ASAN
  ✓ [PATCH v4 8/20] selftests/bpf: Add DENYLIST.asan
  ✓ [PATCH v4 9/20] selftests/bpf: Refactor bpf_get_ksyms() trace helper
  ✓ [PATCH v4 10/20] selftests/bpf: Fix memory leaks in tests
  ✓ [PATCH v4 11/20] selftests/bpf: Fix cleanup in check_fd_array_cnt__fd_array_too_big()
  ✓ [PATCH v4 12/20] veristat: Fix a memory leak for preset ENUMERATOR
  ✓ [PATCH v4 13/20] selftests/bpf: Fix use-after-free in xdp_metadata test
  ✓ [PATCH v4 14/20] selftests/bpf: Fix double thread join in uprobe_multi_test
  ✓ [PATCH v4 15/20] selftests/bpf: Fix resource leaks caused by missing cleanups
  ✓ [PATCH v4 16/20] selftests/bpf: Free bpf_object in test_sysctl
  ✓ [PATCH v4 17/20] selftests/bpf: Fix array bounds warning in jit_disasm_helpers
  ✓ [PATCH v4 18/20] selftests/bpf: Fix out-of-bounds array access bugs reported by ASAN
  ✓ [PATCH v4 19/20] selftests/bpf: Check BPFTOOL env var in detect_bpftool_path()
  ✓ [PATCH v4 20/20] selftests/bpf: Don't override SIGSEGV handler with ASAN
  ---
  ✓ Signed: DKIM/linux.dev
---
Total patches: 20
---
Applying: selftests/bpf: Add simple strscpy() implementation
Applying: selftests/bpf: Replace strcpy() calls with strscpy()
Applying: selftests/bpf: Replace strncpy() with strscpy()
Applying: selftests/bpf: Use strscpy in bpftool_helpers.c
Applying: selftests/bpf: Use memcpy() for bounded non-NULL-terminated copies
Applying: selftests/bpf: Pass through build flags to bpftool and resolve_btfids
Applying: resolve_btfids: Fix memory leaks reported by ASAN
Applying: selftests/bpf: Add DENYLIST.asan
Applying: selftests/bpf: Refactor bpf_get_ksyms() trace helper
Applying: selftests/bpf: Fix memory leaks in tests
Applying: selftests/bpf: Fix cleanup in check_fd_array_cnt__fd_array_too_big()
Applying: veristat: Fix a memory leak for preset ENUMERATOR
Applying: selftests/bpf: Fix use-after-free in xdp_metadata test
Applying: selftests/bpf: Fix double thread join in uprobe_multi_test
Applying: selftests/bpf: Fix resource leaks caused by missing cleanups
Applying: selftests/bpf: Free bpf_object in test_sysctl
Applying: selftests/bpf: Fix array bounds warning in jit_disasm_helpers
Applying: selftests/bpf: Fix out-of-bounds array access bugs reported by ASAN
Applying: selftests/bpf: Check BPFTOOL env var in detect_bpftool_path()
Applying: selftests/bpf: Don't override SIGSEGV handler with ASAN


> 
> [...]