Re: 答复: [外部邮件] Re: [PATCH] x86/sgx: Fix SRCU list traversal
From: Dave Hansen
Date: Mon Feb 23 2026 - 20:14:44 EST
On 2/23/26 16:30, Li,Rongqing(ACG CCN) wrote:
>>> Replace list_for_each_entry_rcu() with list_for_each_entry_srcu() when
>>> traversing the encl->mm_list protected by SRCU. This ensures proper
>>> synchronization annotation and avoids potential lockdep warnings about
>>> incorrect RCU usage.
>>>
>>> The list is protected by encl->srcu, not RCU, so the SRCU-specific
>>> iterator with srcu_read_lock_held() annotation is required.
>>>
>>> Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx>
>> Acked-by: Kai Huang <kai.huang@xxxxxxxxx>
> Thanks for reviewing , and ping
It's a light NAK from me with the current changelog.
I want a wee bit more background and some reasoning _somewhere_ about
why this wasn't a bug when the code went in originally but arguably
became a buglet at some point.