RE: [PATCH 07/62] drm/amdgpu: Unlock a mutex before destroying it

[Wang, Yang(Kevin)]

[AMD Official Use Only - AMD Internal Distribution Only]

Reviewed-by: Yang Wang <kevinyang.wang@xxxxxxx>

Best Regards,
Kevin

-----Original Message-----
From: Bart Van Assche <bart.vanassche@xxxxxxxxx>
Sent: Tuesday, February 24, 2026 6:00 AM
To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>; Will Deacon <will@xxxxxxxxxx>; Boqun Feng <boqun@xxxxxxxxxx>; Waiman Long <longman@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Marco Elver <elver@xxxxxxxxxx>; Christoph Hellwig <hch@xxxxxx>; Steven Rostedt <rostedt@xxxxxxxxxxx>; Nick Desaulniers <ndesaulniers@xxxxxxxxxx>; Nathan Chancellor <nathan@xxxxxxxxxx>; Kees Cook <kees@xxxxxxxxxx>; Jann Horn <jannh@xxxxxxxxxx>; Bart Van Assche <bvanassche@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: [PATCH 07/62] drm/amdgpu: Unlock a mutex before destroying it

[You don't often get email from bart.vanassche@xxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

From: Bart Van Assche <bvanassche@xxxxxxx>

Mutexes must be unlocked before these are destroyed. This has been detected by the Clang thread-safety analyzer.

Cc: Alex Deucher <alexander.deucher@xxxxxxx>
Cc: Christian König <christian.koenig@xxxxxxx>
Cc: Yang Wang <kevinyang.wang@xxxxxxx>
Cc: Hawking Zhang <Hawking.Zhang@xxxxxxx>
Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Fixes: f5e4cc8461c4 ("drm/amdgpu: implement RAS ACA driver framework")
Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
index afe5ca81beec..db7858fe0c3d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
@@ -641,6 +641,7 @@ static void aca_error_fini(struct aca_error *aerr)
                aca_bank_error_remove(aerr, bank_error);

 out_unlock:
+       mutex_unlock(&aerr->lock);
        mutex_destroy(&aerr->lock);
 }