[PATCH v4] timers/migration: Ensure proper resource cleanup on error in tmigr_init
From: Zhan Xusheng
Date: Mon Feb 23 2026 - 21:43:52 EST
Free resources allocated by zalloc_cpumask_var and kcalloc on failure.
Signed-off-by: Zhan Xusheng <zhanxusheng@xxxxxxxxxx>
Reviewed-by: Frederic Weisbecker <frederic@xxxxxxxxxx>
---
kernel/time/timer_migration.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
index c1ed0d5e8de6..b6010790368c 100644
--- a/kernel/time/timer_migration.c
+++ b/kernel/time/timer_migration.c
@@ -2004,7 +2004,7 @@ static int __init tmigr_init(void)
tmigr_level_list = kzalloc_objs(struct list_head,
tmigr_hierarchy_levels);
if (!tmigr_level_list)
- goto err;
+ goto err_free_cpumask;
for (i = 0; i < tmigr_hierarchy_levels; i++)
INIT_LIST_HEAD(&tmigr_level_list[i]);
@@ -2017,15 +2017,24 @@ static int __init tmigr_init(void)
ret = cpuhp_setup_state(CPUHP_TMIGR_PREPARE, "tmigr:prepare",
tmigr_cpu_prepare, NULL);
if (ret)
- goto err;
+ goto err_free_level_list;
ret = cpuhp_setup_state(CPUHP_AP_TMIGR_ONLINE, "tmigr:online",
tmigr_set_cpu_available, tmigr_clear_cpu_available);
if (ret)
- goto err;
+ goto err_remove_prepare_state;
return 0;
+err_remove_prepare_state:
+ cpuhp_remove_state(CPUHP_TMIGR_PREPARE);
+
+err_free_level_list:
+ kfree(tmigr_level_list);
+
+err_free_cpumask:
+ free_cpumask_var(tmigr_available_cpumask);
+
err:
pr_err("Timer migration setup failed\n");
return ret;
--
2.43.0