Re: [PATCH] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers

[Chintan Patel]

> I won't insist since it's a matter of opinion, but IMO get rid of the
> `err` local variable and consistently use `dsi_ctx.accum_err` to store
> the error code in this function. Yeah, it's a bit awkward, but having
> the separate `err` variable just makes it too easy to mess up and use
> it. As one example of where that happened, see commit 61ce50fd8196
> ("drm/panel: jdi-lpm102a188a: Fix error code in jdi_panel_prepare()").
>
> Also: instead of returning right away, I think you want to make sure
> that the GPIO gets set to 0 like the old code did, don't you? I'd be a
> little hesitant changing this unless we can truly prove that the GPIO
> set is not needed or unless we're certain that the GPIO set was
> incorrect (in which case we should fix it in a separate patch).
>
> ...nicely, if you use `dsi_ctx.accum_err` you don't even need a
> "goto". You can just let the "_multi" functions all run and be
> no-ops...
>
> -Doug
Thank you Doug! Those were good points! Will work on v2.