Re: [PATCH] pinctrl: rockchip: Fix configuring a deferred pin

[Linus Walleij]

On Mon, Feb 23, 2026 at 11:57 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxxxxx> wrote:

> Commit e2c58cbe3aff ("pinctrl: rockchip: Simplify locking with
> scoped_guard()") added a scoped_guard() over existing code containing a
> "break" instruction.  That "break" was for the outer (existing)
> for-loop, which now exits inner, scoped_guard() loop.  If GPIO driver
> did not probe, then driver will not bail out, but instead continue to
> configure the pin.
>
> Fix the issue by simplifying the code - the break in original code was
> leading directly to end of the function returning 0, thus we can simply
> return here rockchip_pinconf_defer_pin status.
>
> Reported-by: David Lechner <dlechner@xxxxxxxxxxxx>
> Closes: https://lore.kernel.org/r/f5b38942-a584-4e78-a893-de4a219070b2@xxxxxxxxxxxx/
> Fixes: e2c58cbe3aff ("pinctrl: rockchip: Simplify locking with scoped_guard()")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Patch applied for fixes!

Yours,
Linus Walleij