Re: [PATCH v3 07/19] rv/rvgen: fix typos in automata and generator docstring and comments
From: Gabriele Monaco
Date: Tue Feb 24 2026 - 04:37:50 EST
On Mon, 2026-02-23 at 13:17 -0300, Wander Lairson Costa wrote:
> - # when a transition has more than one lables, they are like
> this
> + # when a transition has more than one labels, they are like
> this
> # "local_irq_enable\nhw_local_irq_enable_n"
> # so split them.
>
Missing one little thing:
s/labels/label/
I'm going to apply it directly on my tree so you don't need to send a V4 just
for this.
Thanks,
Gabriele
> diff --git a/tools/verification/rvgen/rvgen/dot2c.py
> b/tools/verification/rvgen/rvgen/dot2c.py
> index fa44795adef46..9255cc2153a31 100644
> --- a/tools/verification/rvgen/rvgen/dot2c.py
> +++ b/tools/verification/rvgen/rvgen/dot2c.py
> @@ -3,7 +3,7 @@
> #
> # Copyright (C) 2019-2022 Red Hat, Inc. Daniel Bristot de Oliveira
> <bristot@xxxxxxxxxx>
> #
> -# dot2c: parse an automata in dot file digraph format into a C
> +# dot2c: parse an automaton in dot file digraph format into a C
> #
> # This program was written in the development of this paper:
> # de Oliveira, D. B. and Cucinotta, T. and de Oliveira, R. S.
> diff --git a/tools/verification/rvgen/rvgen/dot2k.py
> b/tools/verification/rvgen/rvgen/dot2k.py
> index 47af9f104a829..aedc2a7799b32 100644
> --- a/tools/verification/rvgen/rvgen/dot2k.py
> +++ b/tools/verification/rvgen/rvgen/dot2k.py
> @@ -167,14 +167,14 @@ class da2k(dot2k):
> def __init__(self, *args, **kwargs):
> super().__init__(*args, **kwargs)
> if self.is_hybrid_automata():
> - raise AutomataError("Detected hybrid automata, use the 'ha'
> class")
> + raise AutomataError("Detected hybrid automaton, use the 'ha'
> class")
>
> class ha2k(dot2k):
> """Hybrid automata only"""
> def __init__(self, *args, **kwargs):
> super().__init__(*args, **kwargs)
> if not self.is_hybrid_automata():
> - raise AutomataError("Detected deterministic automata, use the
> 'da' class")
> + raise AutomataError("Detected deterministic automaton, use the
> 'da' class")
> self.trace_h = self._read_template_file("trace_hybrid.h")
> self.__parse_constraints()
>
> diff --git a/tools/verification/rvgen/rvgen/generator.py
> b/tools/verification/rvgen/rvgen/generator.py
> index d932e96dd66d3..988ccdc27fa37 100644
> --- a/tools/verification/rvgen/rvgen/generator.py
> +++ b/tools/verification/rvgen/rvgen/generator.py
> @@ -3,7 +3,7 @@
> #
> # Copyright (C) 2019-2022 Red Hat, Inc. Daniel Bristot de Oliveira
> <bristot@xxxxxxxxxx>
> #
> -# Abtract class for generating kernel runtime verification monitors from
> specification file
> +# Abstract class for generating kernel runtime verification monitors from
> specification file
>
> import platform
> import os